CADForums.net

T.Willey · Guest

I use lisp mostly, and am looking to increase my knowledge of programming within AutoCad, so this is my first attempt on my own.

How can you write /= (not equal) in vba? I have seen some methods like

If Lay <> Document.ActiveLayer Then

But it doesn't seem to work for me. Any tips and or comments on the code is appreciated as I am still learning.

Thanks in advance.
Tim

Sub ChangeAll2Layer0()
Dim BlkCol As Object
Dim BlkObj As Object
Dim Obj As Object
Dim LayCol As Object
Dim Lay As Object

Set LayCol = ThisDrawing.Layers
For Each Lay In LayCol
Lay.Lock = False
Lay.LayerOn = True
If Lay = Document.ActiveLayer Then
Lay.Freeze = False
End If
Next

Set BlkCol = ThisDrawing.Blocks
For Each BlkObj In BlkCol
For Each Obj In BlkObj
Obj.Layer = 0
Next
Next

AcadApplication.ZoomExtents
ThisDrawing.PurgeAll

End Sub

Frank Oquendo · Guest

"<>" is indeed "/=" but only for values. You're comparing objects. VB
uses the Is operator for that:

If Not Lay Is Document.ActiveLayer

Have you considered getting a reference to the active layer or its name
before entering the loop? That's more efficient.

--
There are 10 kinds of people: those who understand binary and those who
don't.

VBA · Guest

Here is your code tighten up a bit.

Public Sub ChangeAll2Layer0()
Dim BlkObj As AcadBlock
Dim Obj As AcadObject
Dim Lay As AcadLayer

For Each Lay In ThisDrawing.Layers
Lay.Lock = False
Lay.LayerOn = True
If Lay = ThisDrawing.ActiveLayer Then
Lay.Freeze = False
End If
Next Lay

For Each BlkObj In ThisDrawing.Blocks
For Each Obj In BlkObj
Obj.Layer = 0
Next Obj
Next BlkObj

Application.ZoomExtents
ThisDrawing.PurgeAll
End Sub

"T.Willey" <nospam@address.withheld> wrote in message
news:4234135.1106850636269.JavaMail.jive@jiveforum2.autodesk.com...

T.Willey · Guest

No I didn't think of doing that, but that would be no problem to add. Will test now.

Thanks.
Tim

T.Willey · Guest

Thanks for the help all.

Now I have a different question. The way it is now working is ok, but it doesn't change the attributes of blocks. How can I write an If and statement? I didn't see anything in the help topics with vba or autocad, and couldn't find anything with a quick search of the ng.

What I'm look for is something like
If And Obj.ObjectName = "AcDbBlockReference" Obj.HasAttributes = True then

I tried it this way also, and it doesn't like it.

If Obj.ObjectName = "AcDbBlockReference" And Obj.HasAttributes = True Then

Then once that is working, to envoke the method to get the attributes is it just
Obj.GetAttributes ??

Here is what I am trying to do, but can't get it to work.
Set BlkCol = ThisDrawing.Blocks
For Each BlkObj In BlkCol
For Each Obj In BlkObj
If Obj.ObjectName = "AcDbBlockReference" And Obj.HasAttributes = True Then
For Each AttObj In Obj.GetAttributes
AttObj.Layer = 0
Next
End If
Obj.Layer = 0
Next
Next

Thanks again.
Tim

Frank Oquendo · Guest

T.Willey wrote:

T.Willey · Guest

I thought that within the block collection the model and paper space blocks resided? If that is true, then wouldn't what I have written search through all model/paper space. Once it comes across a block, then it will test if it has attributes, and if so then it will change them to layer 0 also. That is why I did the double for each call.

Am I totally off base?
Thanks for your help, and patience.
Tim

Frank Oquendo · Guest

T.Willey wrote:

fantum · Guest

T.Willey · Guest

For Each AttObj In Obj.GetAttributes

It doesn't like this line now. I guess it is because Obj.GetAttributes returns as a variant. How would I step though a variant?

Thanks again.
Tim

T.Willey · Guest

Thanks for letting me know. I guess I'm to used to lisp.

Tim

T.Willey · Guest

Here is what I got so far. I found a post that showed one way I'm guessing to work with variants, but when I plugged it in it's not working still.

Tim

Set BlkCol = ThisDrawing.Blocks
For Each BlkObj In BlkCol
If BlkObj.IsLayout = True Then
For Each Obj In BlkObj
If Obj.ObjectName = "AcDbBlockReference" Then
If Obj.HasAttributes = True Then
Set AttObj = Obj.GetAttributes
'For Each AttObj In Obj.GetAttributes
'above didn't work
For i = LBound(AttObj) To UBound(AttObj)
AttObj(i).Layer = 0
'AttObj.Layer = 0
Next
Set AttObj = Obj.GetConstantAttributes
For i = LBound(AttObj) To UBound(AttObj)
AttObj(i).Layer = 0
'For Each AttObj In Obj.GetConstantAttributes
'above didn't work
'AttObj.Layer = 0
Next
End If
End If
Obj.Layer = 0
Next
Else
For Each item In Obj
item.Layer = 0
Next
End If
Next

Frank Oquendo · Guest

T.Willey wrote:

T.Willey · Guest

THANK YOU!!!!!

It works now, after all you help, and others.
Now to see how much more trouble I can get in to.

One question, why did I have to take out the set?

Thanks again to all who helped me.
Tim

Laurie Comerford · Guest

Hi,

That's a great question. When I started programming in AutoCAD, I had a
rule:

Write a line of code like

a = b

If it won't work, change it to
Set a = b

Inevitably it worked to get my code functioning.

As I gained further experience I found that you use Set when you are
assigning an object, and don't use it when dealing with non-object items
like strings, numbers etc.

--

Regards,

Laurie Comerford
www.cadapps.com.au

"T.Willey" <nospam@address.withheld> wrote in message
news:22960059.1106864401849.JavaMail.jive@jiveforum2.autodesk.com...

	CADForums.net Forum Index -> VBA	All times are GMT Goto page 1, 2 Next
Page 1 of 2