CADForums.net

MiD-AwE · Guest

Hey all, I've been working on a LISP mostly composed of bits and pieces from this message board, but I can't figure out what's wrong with this code. Aside from it's bulk ACAD reports that I have to many arguments. Please help me optimize and fix this. I'm sure it's an easy issue I'm just too new to LISP to see the answer. Thank you.

wkiernan · Guest

I think your "too many arguments" problem is because you've sent five strings to ALERT which only takes a single string as an argument. Try this:

(DEFUN C:CHKDWG (/ ss1 blknam blknam1 blknam2
blknam3 blknam4 blknum blknum1 blknum2
blknum3 blknum4
)
(SETQ blknam "NSKIM" blknum 0)
(SETQ ss1
(ssget "X"
(list (cons 0 "INSERT") (cons 2 blknam))
)
)
(if ss1
(progn (SETQ blknum (sslength ss1)))
)
(setq ss1 nil)
(SETQ blknam1 "LIGHT" blknum1 0)
(SETQ ss1
(ssget "X"
(list (cons 0 "INSERT") (cons 2 blknam1))
)
)
(if ss1
(progn (SETQ blknum1 (sslength ss1))
)
)
(setq ss1 nil)
(SETQ blknam2 "MDXDRAIN" blknum 0)
(SETQ ss1
(ssget "X"
(list (cons 0 "INSERT") (cons 2 blknam2))
)
)
(if ss1
(progn
(SETQ blknum2 (sslength ss1))
)
)
(setq ss1 nil)
(SETQ blknam3 "HLFDRAIN" blknum3 0)
(SETQ ss1
(ssget "X"
(list (cons 0 "INSERT") (cons 2 blknam3))
)
)
(if ss1
(progn
(SETQ blknum3 (sslength ss1))
)
)
(setq ss1 nil)
(SETQ blknam4 "DPTHCALL" blknum 0)
(SETQ ss1
(ssget "X"
(list (cons 0 "INSERT") (cons 2 blknam4))
)
)
(if ss1
(progn
(SETQ blknum4 (sslength ss1))
)
)
(setq ss1 nil)
(alert
(strcat
(itoa blknum)
" skimmers found\n"
(Itoa blknum1)
" lights found\n"
(itoa blknum2)
" main drains found\n")
(itoa blknum3)
" secondary main drains found\n"
(itoa blknum4)
"depth markers found."
)
)
(princ)
)

Note that I have set ss1to nil each time after you're done with it. You can only have, I think, 128 selection sets at a time. After that AutoCAD starts acting awfully strange. If you create a selection set ss1 and you don't later set it to nil, it takes up one of the pool. If you overwrite the selection set, e.g.

(setq ss1 (ssget "x" (list (cons 0 "LINE"))))
(setq ss1 (ssget "x" (list (cons 0 "CIRCLE"))))

you've taken up two of the availble selection sets. So when your program is done with a selection set, it's a good idea to "nil it out."

Another tip is that you can set several variables with a single SETQ statement, thus

(SETQ blknam "NSKIM")
(SETQ blknum 0)
(SETQ ss1
(ssget "X"
(list (cons 0 "INSERT") (cons 2 blknam))
)
)

is the equivalent of

(SETQ blknam "NSKIM"
blknum 0
ss1
(ssget "X"
(list (cons 0 "INSERT") (cons 2 blknam))
)
)

Jeff Mishler · Guest

Not to pick nits here, I just want to clear up one little thing.... ;-)

"wkiernan" wrote in message ...

MiD-AwE · Guest

Hey thanks :)

Works but for some reason no matter how many "NSKIM" block are in the drawing it always returns 0.
Any ideas?

TRJ · Guest

Command: ssx
Select object <None>:
Enter filter option [Block
name/Color/Entity/Flag/LAyer/LType/Pick/Style/Thickness/Vector]: b

TRJ · Guest

Sorry all... forgot I was in the customization group ;-)

Names ARE case sensitive. Is the name in upper or lower case in the block
table?

"TRJ" <a0h9rjone@cfl.rr.com> wrote in message news:422e26c9_2@newsprd01...

Jason Piercey · Guest

Command: -block

Enter block name or [?]: test
Specify insertion base point:
Select objects: Specify opposite corner: 1 found

Select objects:

Command: (tblsearch "block" "TEST")
((0 . "BLOCK") (2 . "test") (70 . 0) (10 0.0 0.0 0.0)
(-2 . <Entity name: 7ed58378>))

As you can see, the names are NOT case sensitive
in the table.

--
Autodesk Discussion Group Facilitator

"TRJ" <a0h9rjone@cfl.rr.com> wrote in message news:422e295f$1_2@newsprd01...

wkiernan · Guest

Yep, my mistake, change the line which reads

(SETQ blknam4 "DPTHCALL" blknum 0)

to

(SETQ blknam4 "DPTHCALL" blknum4 0)

TRJ · Guest

Not sure but when I create a "list" with "NSKIM" in it and then do a (member
expr lst) where expression is "nskim", it returns nil. Does it not for you?

"Jason Piercey" <Jason AT atreng DOT com> wrote in message
news:422e2bba_3@newsprd01...

Joe Burke · Guest

The member function is case sensitive when dealing with strings.

Jason's point was the two arguments supplied to the tblsearch function are not case
sensitive.

Joe Burke

BillZ · Guest

(defun c:ChkDwg (/ acaddoc BlkCol BlkNams)
(setq BlkNams (list "NSKIM" "LIGHT" "MDXDRAIN" "HLFDRAIN" "DPTHCALL")
)
;---;
(foreach n BlkNams
(cond ((= n "NSKIM")
(setq blknam "skimmer")
)
((= n "LIGHT")
(setq blknam "light")
)
((= n "MDXDRAIN")
(setq blknam "main drain")
)
((= n "HLFDRAIN")
(setq blknam "secondary main drain or MDX vent")
)
((= n "DPTHCALL")
(setq blknam "depth markers")
)
)
(if (setq ss (ssget "X" (list (cons 0 "INSERT")(cons 2 n))))
(princ (strcat "\n " blknam " found < " (itoa (sslength ss)) " > time(s)."))
(princ (strcat "\n " blknam " NOT found."))
)
)
;---;
(princ)
)

TRJ · Guest

Given. However I do not see where the OP is calling tblsearch in his code.
Did I overlook it? Is case sensitivity possibly why the OP is not finding
his blocks?

"Joe Burke" <joburke@hawaii.rr.com> wrote in message
news:422edeef$1_1@newsprd01...

MiD-AwE · Guest

Sweet,

Much better than what I had. My main goal was not to count the number of times the block was found though that is a very useful function, but I needed to check if the block exists in the drawing and this rewrite is excellent for that. I need to develop this into a full featured checker for our work. For about 75% of our drawings there will only be 1 of each of these items in our drawings (swimming pools are considerably different from standard architecture). So, checking for the existence of said blocks will suffice but on our commercial division counting blocks is essential.

I have made a simple modification of the code to serve both purposes (posted below). Basically, I only added the alert for items not found at all). I'd like to do other functions as well as alert the user if the block is not found at all.

Thanks again to everyone and especially BillZ who seems to always surprise me with near wizardry of LISP :)

BillZ · Guest

You're welcome.

Glad I could help.

Just add the progn(s) and closing parens.

(if (setq ss (ssget "X" (list (cons 0 "INSERT")(cons 2 n))))
(progn
(princ (strcat "\n " blknam " found < " (itoa (sslength ss)) " > time(s)."))
do something else here if found.
) ;end progn
(progn (ALERT (strcat "\nNo " blknam " found in drawing!"))<Need to do other stuff here. Is it as easy as that?>)<<<
Do whatever if not found.
) ;end progn
)

Joe Burke · Guest

I don't know whether case is an issue since I haven't studied the thread in detail.

But I see your point, so forget what I said.

Joe Burke

"TRJ" <a0h9rjone@cfl.rr.com> wrote in message news:422f06a1$1_3@newsprd01...

	CADForums.net Forum Index -> Customization	All times are GMT Goto page 1, 2 Next
Page 1 of 2